diff options
| author | Sergey Popovich <popovich_sergei@mail.ru> | 2014-05-06 18:23:08 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-05-07 17:14:32 -0400 |
| commit | aeefa1ecfc799b0ea2c4979617f14cecd5cccbfd (patch) | |
| tree | 89e426b9a1e402fae250984d2083c5148358b5bb | |
| parent | 7fc1c5f3ca2ade64c8a7c78a1df3130f74f383e4 (diff) | |
| download | op-kernel-dev-aeefa1ecfc799b0ea2c4979617f14cecd5cccbfd.zip op-kernel-dev-aeefa1ecfc799b0ea2c4979617f14cecd5cccbfd.tar.gz | |
ipv4: fib_semantics: increment fib_info_cnt after fib_info allocation
Increment fib_info_cnt in fib_create_info() right after successfuly
alllocating fib_info structure, overwise fib_metrics allocation failure
leads to fib_info_cnt incorrectly decremented in free_fib_info(), called
on error path from fib_create_info().
Signed-off-by: Sergey Popovich <popovich_sergei@mail.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/fib_semantics.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 8a043f0..b10cd43a 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -821,13 +821,13 @@ struct fib_info *fib_create_info(struct fib_config *cfg) fi = kzalloc(sizeof(*fi)+nhs*sizeof(struct fib_nh), GFP_KERNEL); if (fi == NULL) goto failure; + fib_info_cnt++; if (cfg->fc_mx) { fi->fib_metrics = kzalloc(sizeof(u32) * RTAX_MAX, GFP_KERNEL); if (!fi->fib_metrics) goto failure; } else fi->fib_metrics = (u32 *) dst_default_metrics; - fib_info_cnt++; fi->fib_net = hold_net(net); fi->fib_protocol = cfg->fc_protocol; |
