diff options
| author | Davi Arnaut <davi.arnaut@gmail.com> | 2005-11-07 00:59:37 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 07:53:39 -0800 |
| commit | 53b27584db0446e356c86b3aa43f5107b0170704 (patch) | |
| tree | 82b67a2ac88716cca4eb638f5475e875d6feb1ec | |
| parent | ce44eeb6906cf2b093b76ea69b952621712a4a3c (diff) | |
| download | op-kernel-dev-53b27584db0446e356c86b3aa43f5107b0170704.zip op-kernel-dev-53b27584db0446e356c86b3aa43f5107b0170704.tar.gz | |
[PATCH] smbfs: 'names_cache' memory leak
Data allocated with "__getname()" should always be free'd with "__putname()"
because of the AUDITSYSCALL code.
Signed-off-by: Davi Arnaut <davi.arnaut@gmail.com>
Cc: Urban Widmark <urban@teststation.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | fs/smbfs/symlink.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/smbfs/symlink.c b/fs/smbfs/symlink.c index 0c64bc3..cdc53c4 100644 --- a/fs/smbfs/symlink.c +++ b/fs/smbfs/symlink.c @@ -45,7 +45,7 @@ static void *smb_follow_link(struct dentry *dentry, struct nameidata *nd) int len = smb_proc_read_link(server_from_dentry(dentry), dentry, link, PATH_MAX - 1); if (len < 0) { - putname(link); + __putname(link); link = ERR_PTR(len); } else { link[len] = 0; @@ -59,7 +59,7 @@ static void smb_put_link(struct dentry *dentry, struct nameidata *nd, void *p) { char *s = nd_get_link(nd); if (!IS_ERR(s)) - putname(s); + __putname(s); } struct inode_operations smb_link_inode_operations = |
