diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2015-03-20 14:18:12 +1030 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2015-03-20 15:07:08 +1030 |
| commit | 88ad1a147e2c84d33cb50f5ebff1ece5e0cd4383 (patch) | |
| tree | 787bf5d65989c9bf09391f606f12f43dfee69c3d | |
| parent | c58616580ea520aab8dacef787d855bea3e81c25 (diff) | |
| download | op-kernel-dev-88ad1a147e2c84d33cb50f5ebff1ece5e0cd4383.zip op-kernel-dev-88ad1a147e2c84d33cb50f5ebff1ece5e0cd4383.tar.gz | |
lguest: fix pending interrupt test.
Denys says:
TEST with zero will always set ZF. Thus, "jnz send_interrupts" never jumps.
We get interrupts regularly enough that this didn't cause immediate problems.
Reported-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| -rw-r--r-- | arch/x86/lguest/head_32.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/lguest/head_32.S b/arch/x86/lguest/head_32.S index 6ddfe4f..05b0a85 100644 --- a/arch/x86/lguest/head_32.S +++ b/arch/x86/lguest/head_32.S @@ -84,7 +84,7 @@ ENTRY(lg_irq_enable) * set lguest_data.irq_pending to X86_EFLAGS_IF. If it's not zero, we * jump to send_interrupts, otherwise we're done. */ - testl $0, lguest_data+LGUEST_DATA_irq_pending + cmpl $0, lguest_data+LGUEST_DATA_irq_pending jnz send_interrupts /* * One cool thing about x86 is that you can do many things without using |
