diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-05-30 10:50:46 +0300 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-06-26 17:41:44 -0700 |
| commit | 5d65f91896197bd047f97ed8e7792b06de491eac (patch) | |
| tree | 9eaf4f6f1531179197798251661759cd1a825e8e | |
| parent | 607be2cff4f4899f47ef906eba5b147abc3c5da4 (diff) | |
| download | op-kernel-dev-5d65f91896197bd047f97ed8e7792b06de491eac.zip op-kernel-dev-5d65f91896197bd047f97ed8e7792b06de491eac.tar.gz | |
[SCSI] fnic: potential dead lock in fnic_is_abts_pending()
There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is
false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hiral Patel <hiralpat@cisco.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/fnic/fnic_scsi.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index be99e75..a97e6e5 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -2432,11 +2432,9 @@ int fnic_is_abts_pending(struct fnic *fnic, struct scsi_cmnd *lr_sc) "Found IO in %s on lun\n", fnic_ioreq_state_to_str(CMD_STATE(sc))); - if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) { - spin_unlock_irqrestore(io_lock, flags); + if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) ret = 1; - continue; - } + spin_unlock_irqrestore(io_lock, flags); } return ret; |
