summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-08-18 02:29:30 +0000
committerDavid S. Miller <davem@davemloft.net>2010-08-19 00:44:03 -0700
commit502820a3161e2f228125977d133dd80eea2932d1 (patch)
treec199c94802b332ba975c9c20a2160335d0865478
parent1003201a73daed739747b9a6c2c39c57aad5878b (diff)
downloadop-kernel-dev-502820a3161e2f228125977d133dd80eea2932d1.zip
op-kernel-dev-502820a3161e2f228125977d133dd80eea2932d1.tar.gz
netxen: fix a race in netxen_nic_get_stats()
Dont clear netdev->stats, it might give transient wrong values to concurrent stat readers. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/netxen/netxen_nic_main.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index fd86e18..cb30df1 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -2032,8 +2032,6 @@ struct net_device_stats *netxen_nic_get_stats(struct net_device *netdev)
struct netxen_adapter *adapter = netdev_priv(netdev);
struct net_device_stats *stats = &netdev->stats;
- memset(stats, 0, sizeof(*stats));
-
stats->rx_packets = adapter->stats.rx_pkts + adapter->stats.lro_pkts;
stats->tx_packets = adapter->stats.xmitfinished;
stats->rx_bytes = adapter->stats.rxbytes;
OpenPOWER on IntegriCloud