diff options
| author | Bob Peterson <rpeterso@redhat.com> | 2012-01-06 16:48:50 -0500 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2012-01-11 09:23:26 +0000 |
| commit | 49528b4e479195e5db4fe51fcd5ddd97901efc16 (patch) | |
| tree | 3e27260f25133fbaf7b8d95faa9b73016eac1b13 | |
| parent | e0c2a9aa1e68455dc3439e95d85cabcaff073666 (diff) | |
| download | op-kernel-dev-49528b4e479195e5db4fe51fcd5ddd97901efc16.zip op-kernel-dev-49528b4e479195e5db4fe51fcd5ddd97901efc16.tar.gz | |
GFS2: Fix a use-after-free that coverity spotted
In function gfs2_inplace_release it was trying to unlock a gfs2_holder
structure associated with a reservation, after said reservation was
freed. The problem is that the statements have the wrong order.
This patch corrects the order so that the reservation is freed after
the gfs2_holder is unlocked.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
| -rw-r--r-- | fs/gfs2/rgrp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 2223462..981bfa3 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1108,9 +1108,9 @@ void gfs2_inplace_release(struct gfs2_inode *ip) { struct gfs2_blkreserv *rs = ip->i_res; - gfs2_blkrsv_put(ip); if (rs->rs_rgd_gh.gh_gl) gfs2_glock_dq_uninit(&rs->rs_rgd_gh); + gfs2_blkrsv_put(ip); } /** |
