diff options
| author | Matthias Kaehlcke <mka@chromium.org> | 2017-03-16 15:26:52 -0700 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2017-03-29 18:57:25 -0400 |
| commit | 342e91578eb6909529bc7095964cd44b9c057c4e (patch) | |
| tree | fbfd92bbee0e5e29bed643a09021c234bcb2d4e3 | |
| parent | 2a4c22426955d4fc04069811997b7390c0fb858e (diff) | |
| download | op-kernel-dev-342e91578eb6909529bc7095964cd44b9c057c4e.zip op-kernel-dev-342e91578eb6909529bc7095964cd44b9c057c4e.tar.gz | |
selinux: Remove unnecessary check of array base in selinux_set_mapping()
'perms' will never be NULL since it isn't a plain pointer but an array
of u32 values.
This fixes the following warning when building with clang:
security/selinux/ss/services.c:158:16: error: address of array
'p_in->perms' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
while (p_in->perms && p_in->perms[k]) {
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
| -rw-r--r-- | security/selinux/ss/services.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index b4aa491..60d9b02 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -157,7 +157,7 @@ static int selinux_set_mapping(struct policydb *pol, } k = 0; - while (p_in->perms && p_in->perms[k]) { + while (p_in->perms[k]) { /* An empty permission string skips ahead */ if (!*p_in->perms[k]) { k++; |
