summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2013-10-25 11:16:58 +0200
committerJohannes Berg <johannes.berg@intel.com>2013-11-25 16:50:07 +0100
commit7fa322c878d70e38675f50e17acdce7fa3f5ac8c (patch)
tree2e25ac0a6badf54e809a708d54146d1b8144d9ca
parent9fe271af7d4de96471c5aaee2f4d0d1576050497 (diff)
downloadop-kernel-dev-7fa322c878d70e38675f50e17acdce7fa3f5ac8c.zip
op-kernel-dev-7fa322c878d70e38675f50e17acdce7fa3f5ac8c.tar.gz
nl80211: check nla_nest_start() return value
Coverity pointed out that we might dereference NULL later if nla_nest_start() returns a failure. This isn't really true since we'd bomb out before, but we should check the return value directly, so do that. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/wireless/nl80211.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index f1370ed..e20c27f 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -11094,6 +11094,8 @@ void cfg80211_report_wowlan_wakeup(struct wireless_dev *wdev,
struct nlattr *reasons;
reasons = nla_nest_start(msg, NL80211_ATTR_WOWLAN_TRIGGERS);
+ if (!reasons)
+ goto free_msg;
if (wakeup->disconnect &&
nla_put_flag(msg, NL80211_WOWLAN_TRIG_DISCONNECT))
OpenPOWER on IntegriCloud