summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaud Patard <apatard@mandriva.com>2006-09-16 12:15:36 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-09-16 12:54:30 -0700
commit55ebcc38a5f6d40e4c41447e413ef842b803980f (patch)
tree88958844c61fd9772e86a70bde2f274fb8f0d814
parente1ed7ac77b63abb6b3a2c0b4b070f50da5b1fb2f (diff)
downloadop-kernel-dev-55ebcc38a5f6d40e4c41447e413ef842b803980f.zip
op-kernel-dev-55ebcc38a5f6d40e4c41447e413ef842b803980f.tar.gz
[PATCH] IPMI: Fix oops on ipmi_msghandler removal for non ipmi systems
When the ipmi_si module is loaded on a system without any ipmi device, it fails with nodev. It would be fine if all resources were freed. A call to device_unregister() is missing, resulting to a oops when you remove the ipmi_msghandler. Signed-off-by: Arnaud Patard <apatard@mandriva.com> Acked-by: Corey Minyard <minyard@acm.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/char/ipmi/ipmi_si_intf.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index f57eba0..31b5940 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2481,6 +2481,7 @@ static __devinit int init_ipmi_si(void)
#ifdef CONFIG_PCI
pci_unregister_driver(&ipmi_pci_driver);
#endif
+ driver_unregister(&ipmi_driver);
printk("ipmi_si: Unable to find any System Interface(s)\n");
return -ENODEV;
} else {
OpenPOWER on IntegriCloud