diff options
author | Oder Chiou <oder_chiou@realtek.com> | 2016-06-17 11:02:23 +0800 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2016-06-22 16:02:04 +0100 |
commit | b63d4d13ac7b8f947407a7eb44fdc40fadc8c5b8 (patch) | |
tree | 47a4c3859311bb7def87e06469ea59c084257281 | |
parent | 6eebf35b0e4a02248f7dba5d1719c6896afe41ba (diff) | |
download | op-kernel-dev-b63d4d13ac7b8f947407a7eb44fdc40fadc8c5b8.zip op-kernel-dev-b63d4d13ac7b8f947407a7eb44fdc40fadc8c5b8.tar.gz |
ASoC: rt5514: Fix the issue that the variable dereferenced before checking
The patch fixes the issue that variable dereferenced before checking
'rt5514_dsp->substream'. Move the assignment to after the variable
checking of 'rt5514_dsp->substream'.
Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/codecs/rt5514-spi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index 8a9382e..743f509 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -80,7 +80,7 @@ static void rt5514_spi_copy_work(struct work_struct *work) { struct rt5514_dsp *rt5514_dsp = container_of(work, struct rt5514_dsp, copy_work.work); - struct snd_pcm_runtime *runtime = rt5514_dsp->substream->runtime; + struct snd_pcm_runtime *runtime; size_t period_bytes, truncated_bytes = 0; mutex_lock(&rt5514_dsp->dma_lock); @@ -89,6 +89,7 @@ static void rt5514_spi_copy_work(struct work_struct *work) goto done; } + runtime = rt5514_dsp->substream->runtime; period_bytes = snd_pcm_lib_period_bytes(rt5514_dsp->substream); if (rt5514_dsp->buf_size - rt5514_dsp->dsp_offset < period_bytes) |