diff options
| author | Russell King <rmk+kernel@arm.linux.org.uk> | 2016-01-26 13:39:34 +0000 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2016-02-29 11:03:14 +0100 |
| commit | 96776200898cf9c1965b9f8b9a128e94bb6dce18 (patch) | |
| tree | 61c79691461dee5b2374994a99bd9e24d59152a8 | |
| parent | ddfe954d364674ea9a492506e6ec6596b9f49b62 (diff) | |
| download | op-kernel-dev-96776200898cf9c1965b9f8b9a128e94bb6dce18.zip op-kernel-dev-96776200898cf9c1965b9f8b9a128e94bb6dce18.tar.gz | |
mmc: sdhci: move initialisation of command error member
When a command is started, logically it has no error. Initialise the
command's error member to zero whenever we start a command.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
[ Goes with "mmc: sdhci: fix command response CRC error handling" ]
Cc: stable@vger.kernel.org # v4.5+
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/host/sdhci.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index fd91399..43d8717 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1003,6 +1003,9 @@ void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd) WARN_ON(host->cmd); + /* Initially, a command has no error */ + cmd->error = 0; + /* Wait max 10 ms */ timeout = 10; @@ -1097,8 +1100,6 @@ static void sdhci_finish_command(struct sdhci_host *host) } } - host->cmd->error = 0; - /* Finished CMD23, now send actual command. */ if (host->cmd == host->mrq->sbc) { host->cmd = NULL; |
