summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikith Ganigarakoppal <Nikith.Ganigarakoppal@pmcs.com>2013-10-30 16:13:22 +0530
committerJames Bottomley <JBottomley@Parallels.com>2013-12-02 10:33:20 -0800
commit34a9b81b476ea0fa7a2e7ec642830f690eb093aa (patch)
tree79f94fb5fdfe81d34f913bcaf76d3e8c33160027
parent94f33c16f2108ad02599de2459c903ad45d825dc (diff)
downloadop-kernel-dev-34a9b81b476ea0fa7a2e7ec642830f690eb093aa.zip
op-kernel-dev-34a9b81b476ea0fa7a2e7ec642830f690eb093aa.tar.gz
[SCSI] pm80xx: Fix for direct attached device.
In case of direct attached SATA device delay is not enough. It will give crash for set device state command response and wait_for_completion is the best solution for this. Signed-off-by: Nikith.Ganigarakoppal@pmcs.com Signed-off-by: Anandkumar.Santhanam@pmcs.com Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r--drivers/scsi/pm8001/pm8001_sas.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index f4eb18e..f50ac44 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -1098,15 +1098,17 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *lun)
struct pm8001_tmf_task tmf_task;
struct pm8001_device *pm8001_dev = dev->lldd_dev;
struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);
+ DECLARE_COMPLETION_ONSTACK(completion_setstate);
if (dev_is_sata(dev)) {
struct sas_phy *phy = sas_get_local_phy(dev);
rc = pm8001_exec_internal_task_abort(pm8001_ha, pm8001_dev ,
dev, 1, 0);
rc = sas_phy_reset(phy, 1);
sas_put_local_phy(phy);
+ pm8001_dev->setds_completion = &completion_setstate;
rc = PM8001_CHIP_DISP->set_dev_state_req(pm8001_ha,
pm8001_dev, 0x01);
- msleep(2000);
+ wait_for_completion(&completion_setstate);
} else {
tmf_task.tmf = TMF_LU_RESET;
rc = pm8001_issue_ssp_tmf(dev, lun, &tmf_task);
OpenPOWER on IntegriCloud