summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2012-06-12 14:20:26 +1000
committerBen Myers <bpm@sgi.com>2012-06-21 12:32:43 -0500
commit079da28c64ebeca357adae77aea3ae7160e45d98 (patch)
treeccaa8d7eaf6454522ccab6c6f9ad5bda622e5f80
parent76e8f1386673b864cfca3c24c4d5814740e76465 (diff)
downloadop-kernel-dev-079da28c64ebeca357adae77aea3ae7160e45d98.zip
op-kernel-dev-079da28c64ebeca357adae77aea3ae7160e45d98.tar.gz
xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near
When we fail to find an matching extent near the requested extent specification during a left-right distance search in xfs_alloc_ag_vextent_near, we fail to free the original cursor that we used to look up the XFS_BTNUM_CNT tree and hence leak it. Reported-by: Chris J Arges <chris.j.arges@canonical.com> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r--fs/xfs/xfs_alloc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index a996e39..9d1aeb7 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -1080,6 +1080,7 @@ restart:
goto restart;
}
+ xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
trace_xfs_alloc_size_neither(args);
args->agbno = NULLAGBLOCK;
return 0;
OpenPOWER on IntegriCloud