summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Lameter <cl@linux.com>2012-09-11 19:49:38 +0000
committerPekka Enberg <penberg@kernel.org>2012-09-19 09:58:06 +0300
commitf28510d30c7f03daa290019fbc57ad8277347614 (patch)
treeaea777471b79ab19a508155fd69e3b4d2a5cc97c
parent9df53b154ac712c87db1170057aa6df05eb7bdbd (diff)
downloadop-kernel-dev-f28510d30c7f03daa290019fbc57ad8277347614.zip
op-kernel-dev-f28510d30c7f03daa290019fbc57ad8277347614.tar.gz
slab: Only define slab_error for DEBUG
On Tue, 11 Sep 2012, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (sparc64 defconfig) > produced this warning: > > mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function] > > Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common > function for kmem_cache_destroy"). All uses of slab_error() are now > guarded by DEBUG. There is no use case left for slab builds without DEBUG. Signed-off-by: Christoph Lameter <cl@linux.com> Signed-off-by: Pekka Enberg <penberg@kernel.org>
-rw-r--r--mm/slab.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/slab.c b/mm/slab.c
index 11d9af5..8524923 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -803,6 +803,7 @@ static void cache_estimate(unsigned long gfporder, size_t buffer_size,
*left_over = slab_size - nr_objs*buffer_size - mgmt_size;
}
+#if DEBUG
#define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)
static void __slab_error(const char *function, struct kmem_cache *cachep,
@@ -812,6 +813,7 @@ static void __slab_error(const char *function, struct kmem_cache *cachep,
function, cachep->name, msg);
dump_stack();
}
+#endif
/*
* By default on NUMA we use alien caches to stage the freeing of
OpenPOWER on IntegriCloud