summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Tokarev <mjt@tls.msk.ru>2009-10-13 22:22:46 +0200
committerMichal Marek <mmarek@suse.cz>2009-12-12 13:08:13 +0100
commit4a2ff67c88211026afcbdbc190c13f705dae1b59 (patch)
tree6d478129b2000ad3abdfacc5b14c9ab2289e77ec
parent053fe57ac249a9531c396175778160d9e9509399 (diff)
downloadop-kernel-dev-4a2ff67c88211026afcbdbc190c13f705dae1b59.zip
op-kernel-dev-4a2ff67c88211026afcbdbc190c13f705dae1b59.tar.gz
kbuild: fix bzImage build for x86
As has been discussed previously (and Sam has been CC'ed), the fix is still incorrect. It replaces "echo -ne" with "/bin/echo -ne", but neither of the two are guaranteed to support the necessary arguments and necessary (hexadecimal) escape sequences. What should be used here is printf(1). The trivial patch below (on top of these kbuild changes) fixes this issue. Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Michal Marek <mmarek@suse.cz>
-rw-r--r--scripts/Makefile.lib2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index ffdafb2..d9f0cb8 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -208,7 +208,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \
# Bzip2 and LZMA do not include size in file... so we have to fake that;
# append the size as a 32-bit littleendian number as gzip does.
-size_append = /bin/echo -ne $(shell \
+size_append = printf $(shell \
dec_size=0; \
for F in $1; do \
fsize=$$(stat -c "%s" $$F); \
OpenPOWER on IntegriCloud