diff options
| author | Mark Fasheh <mfasheh@suse.com> | 2011-03-22 17:20:26 +0000 |
|---|---|---|
| committer | root <Chris Mason chris.mason@oracle.com> | 2011-03-28 05:37:42 -0400 |
| commit | 3ab3564f018b9b265d0258e4a231794bacd5ad85 (patch) | |
| tree | 53bb771dbb18194a9d13ce2c84c81f2ab834b7e5 | |
| parent | 75e7cb7fe0c391561bd3af36515be3f3c64a04c6 (diff) | |
| download | op-kernel-dev-3ab3564f018b9b265d0258e4a231794bacd5ad85.zip op-kernel-dev-3ab3564f018b9b265d0258e4a231794bacd5ad85.tar.gz | |
btrfs: return EXDEV when linking from different subvolumes
btrfs_link returns EPERM if a cross-subvolume link is attempted.
However, in this case I believe EXDEV to be the more appropriate value.
>From the link(2) man page:
EXDEV oldpath and newpath are not on the same mounted file system. (Linux
permits a file system to be mounted at multiple points, but link()
does not work across different mount points, even if the same file
system is mounted on both.)
This matters because an application may have different behaviors based on
return codes.
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
| -rw-r--r-- | fs/btrfs/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 7a7a202..67fd6e9 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -4817,7 +4817,7 @@ static int btrfs_link(struct dentry *old_dentry, struct inode *dir, /* do not allow sys_link's with other subvols of the same device */ if (root->objectid != BTRFS_I(inode)->root->objectid) - return -EPERM; + return -EXDEV; btrfs_inc_nlink(inode); inode->i_ctime = CURRENT_TIME; |
