summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Hunter <ext-adrian.hunter@nokia.com>2008-11-05 16:09:04 +0200
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2008-11-07 12:11:52 +0200
commit7e2d9bfa4eabee3e1919a40f20d2ef8b569bd07e (patch)
treee79bfe087b5eea815bd584637fab1b14d357c9b1
parente84461ad9c4f0ff91ab8553596acdb7bf5522df4 (diff)
downloadop-kernel-dev-7e2d9bfa4eabee3e1919a40f20d2ef8b569bd07e.zip
op-kernel-dev-7e2d9bfa4eabee3e1919a40f20d2ef8b569bd07e.tar.gz
UBIFS: allow for gaps when dirtying the LPT
The LPT may have gaps in it because initially empty LEBs are not added by mkfs.ubifs - because it does not know how many there are. Then UBIFS allocates empty LEBs in the reverse order that they are discovered i.e. they are added to, and removed from, the front of a list. That creates a gap in the middle of the LPT. The function dirtying the LPT tree (for the purpose of small model garbage collection) assumed that a gap could only occur at the very end of the LPT and stopped dirtying prematurely, which in turn resulted in the LPT running out of space - something that is designed to be impossible. Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
-rw-r--r--fs/ubifs/lpt_commit.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c
index eed5a00..a41434b 100644
--- a/fs/ubifs/lpt_commit.c
+++ b/fs/ubifs/lpt_commit.c
@@ -571,8 +571,6 @@ static struct ubifs_pnode *next_pnode(struct ubifs_info *c,
/* We assume here that LEB zero is never an LPT LEB */
if (nnode->nbranch[iip].lnum)
return ubifs_get_pnode(c, nnode, iip);
- else
- return NULL;
}
/* Go up while can't go right */
OpenPOWER on IntegriCloud