diff options
| author | Russell King <rmk+lkml@arm.linux.org.uk> | 2006-11-10 12:27:53 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-11-13 07:40:42 -0800 |
| commit | d8b295f29091310d746509bb6d5828aaf4907a18 (patch) | |
| tree | db49c0b071d744e7687723c5ae45cf1b02640b97 | |
| parent | e40c67597eac7a0b0e676867517b01a5a57f7b4b (diff) | |
| download | op-kernel-dev-d8b295f29091310d746509bb6d5828aaf4907a18.zip op-kernel-dev-d8b295f29091310d746509bb6d5828aaf4907a18.tar.gz | |
[PATCH] Fix missing parens in set_personality()
If you call set_personality() with an expression such as:
set_personality(foo ? PERS_FOO1 : PERS_FOO2);
then this evaluates to:
((current->personality == foo ? PERS_FOO1 : PERS_FOO2) ? ...
which is obviously not the intended result. Add the missing parents
to ensure this gets evaluated as expected:
((current->personality == (foo ? PERS_FOO1 : PERS_FOO2)) ? ...
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | include/linux/personality.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/personality.h b/include/linux/personality.h index bf4cf20..012cd55 100644 --- a/include/linux/personality.h +++ b/include/linux/personality.h @@ -114,7 +114,7 @@ struct exec_domain { * Change personality of the currently running process. */ #define set_personality(pers) \ - ((current->personality == pers) ? 0 : __set_personality(pers)) + ((current->personality == (pers)) ? 0 : __set_personality(pers)) #endif /* __KERNEL__ */ |
