diff options
| author | Xiubo Li <Li.Xiubo@freescale.com> | 2014-09-28 17:29:37 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2014-09-28 11:49:42 +0100 |
| commit | 6596aa047b624aeec2ea321962cfdecf9953a383 (patch) | |
| tree | b9173cd495e9f4a80c97d2094d4e1d2f2e2df327 | |
| parent | 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9 (diff) | |
| download | op-kernel-dev-6596aa047b624aeec2ea321962cfdecf9953a383.zip op-kernel-dev-6596aa047b624aeec2ea321962cfdecf9953a383.tar.gz | |
ASoC: core: fix possible ZERO_SIZE_PTR pointer dereferencing error.
Since we cannot make sure the 'params->num_regs' will always be none
zero here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).
So this patch fix this with just doing the zero check before calling
kmemdup().
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
| -rw-r--r-- | sound/soc/soc-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d4bfd4a..ae48f10 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3203,7 +3203,7 @@ int snd_soc_bytes_put(struct snd_kcontrol *kcontrol, unsigned int val, mask; void *data; - if (!component->regmap) + if (!component->regmap || !params->num_regs) return -EINVAL; len = params->num_regs * component->val_bytes; |
