diff options
| author | Steve VanDeBogart <vandebo-lkml@NerdBox.Net> | 2008-08-26 15:14:36 -0700 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-08-27 09:10:09 +0200 |
| commit | 2633f0e57b1127f4060d70bf460140dc9bb19386 (patch) | |
| tree | db67beb9715fee165f8c8baaee47fc023b26dceb | |
| parent | 74870172824a78640ec4f03058d9bd35dfa08618 (diff) | |
| download | op-kernel-dev-2633f0e57b1127f4060d70bf460140dc9bb19386.zip op-kernel-dev-2633f0e57b1127f4060d70bf460140dc9bb19386.tar.gz | |
exit signals: use of uninitialized field notify_count
task->signal->notify_count is only initialized if
task->signal->group_exit_task is not NULL. Reorder a conditional so
that uninitialised memory is not used. Found by Valgrind.
Signed-off-by: Steve VanDeBogart <vandebo-lkml@nerdbox.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | kernel/exit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/exit.c b/kernel/exit.c index 38ec406..75c6473 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -918,8 +918,8 @@ static void exit_notify(struct task_struct *tsk, int group_dead) /* mt-exec, de_thread() is waiting for us */ if (thread_group_leader(tsk) && - tsk->signal->notify_count < 0 && - tsk->signal->group_exit_task) + tsk->signal->group_exit_task && + tsk->signal->notify_count < 0) wake_up_process(tsk->signal->group_exit_task); write_unlock_irq(&tasklist_lock); |
