diff options
| author | Eric Sandeen <sandeen@redhat.com> | 2014-05-05 17:27:06 +1000 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2014-05-05 17:27:06 +1000 |
| commit | f58522c5a47a1862c6b3fad97ea9285c5d68199d (patch) | |
| tree | 38014a3199297f7b7ccece36eb8ad18d8072943c | |
| parent | 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc (diff) | |
| download | op-kernel-dev-f58522c5a47a1862c6b3fad97ea9285c5d68199d.zip op-kernel-dev-f58522c5a47a1862c6b3fad97ea9285c5d68199d.tar.gz | |
xfs: bulletfproof xfs_qm_scall_trunc_qfiles()
Coverity noticed that if we sent junk into
xfs_qm_scall_trunc_qfiles(), we could get back an
uninitialized error value. So sanitize the flags we
will accept, and initialize error anyway for good measure.
(This bug may have been introduced via c61a9e39).
Should resolve Coverity CID 1163872.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
| -rw-r--r-- | fs/xfs/xfs_qm_syscalls.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c index 3daf5ea..f35f13b 100644 --- a/fs/xfs/xfs_qm_syscalls.c +++ b/fs/xfs/xfs_qm_syscalls.c @@ -278,9 +278,10 @@ xfs_qm_scall_trunc_qfiles( xfs_mount_t *mp, uint flags) { - int error; + int error = EINVAL; - if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0) { + if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0 || + (flags & ~XFS_DQ_ALLTYPES)) { xfs_debug(mp, "%s: flags=%x m_qflags=%x", __func__, flags, mp->m_qflags); return XFS_ERROR(EINVAL); |
