summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDietmar Eggemann <Dietmar.Eggemann@arm.com>2014-04-30 14:39:38 +0100
committerIngo Molnar <mingo@kernel.org>2014-05-22 11:16:30 +0200
commitcaffcdd8d27ba78730d5540396ce72ad022aff2c (patch)
treeed50e770fcc9c608ba39ab38924bb02fd63c8270
parentc515db8cd311ef77b2dc7cbd6b695022655bb0f3 (diff)
downloadop-kernel-dev-caffcdd8d27ba78730d5540396ce72ad022aff2c.zip
op-kernel-dev-caffcdd8d27ba78730d5540396ce72ad022aff2c.tar.gz
sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups()
There is no need to zero struct sched_group member cpumask and struct sched_group_power member power since both structures are already allocated as zeroed memory in __sdt_alloc(). This patch has been tested with BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power); in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including CPU hotplug scenarios. Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--kernel/sched/core.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45d077e..6340c60 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu)
continue;
group = get_group(i, sdd, &sg);
- cpumask_clear(sched_group_cpus(sg));
- sg->sgp->power = 0;
cpumask_setall(sched_group_mask(sg));
for_each_cpu(j, span) {
OpenPOWER on IntegriCloud