diff options
| author | Jens Axboe <axboe@suse.de> | 2006-05-03 10:35:10 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@nelson.home.kernel.dk> | 2006-05-04 06:55:12 +0200 |
| commit | bfc4ee39fdbb2deb8864785d5e5bc5cdd3b31a69 (patch) | |
| tree | 6f5f678cd07a4c65c1e7ea78f911fdd0932b0c7e | |
| parent | 5dea5176e5c32ef9f0d1a41d28427b3bf6881b3a (diff) | |
| download | op-kernel-dev-bfc4ee39fdbb2deb8864785d5e5bc5cdd3b31a69.zip op-kernel-dev-bfc4ee39fdbb2deb8864785d5e5bc5cdd3b31a69.tar.gz | |
[PATCH] splice: fix unlocking of page on error ->prepare_write()
Looking at generic_file_buffered_write(), we need to unlock_page() if
prepare write fails and it isn't due to racing with truncate().
Also trim the size if ->prepare_write() fails, if we have to.
Signed-off-by: Jens Axboe <axboe@suse.de>
| -rw-r--r-- | fs/splice.c | 19 |
1 files changed, 16 insertions, 3 deletions
diff --git a/fs/splice.c b/fs/splice.c index 7fb0497..27f5e37 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -647,11 +647,24 @@ find_page: } ret = mapping->a_ops->prepare_write(file, page, offset, offset+this_len); - if (ret == AOP_TRUNCATED_PAGE) { + if (unlikely(ret)) { + loff_t isize = i_size_read(mapping->host); + + if (ret != AOP_TRUNCATED_PAGE) + unlock_page(page); page_cache_release(page); - goto find_page; - } else if (ret) + if (ret == AOP_TRUNCATED_PAGE) + goto find_page; + + /* + * prepare_write() may have instantiated a few blocks + * outside i_size. Trim these off again. + */ + if (sd->pos + this_len > isize) + vmtruncate(mapping->host, isize); + goto out; + } if (buf->page != page) { /* |
