diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2005-10-12 15:10:01 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-10-12 15:10:01 -0700 |
| commit | ab4060e858e36129f9319ef0fa055347ad60e1d5 (patch) | |
| tree | c3d28036801fcab8529bd8ee977fafd755fb3da4 | |
| parent | eeb2b8560676e454ad37ee30b49bc7d897edc9be (diff) | |
| download | op-kernel-dev-ab4060e858e36129f9319ef0fa055347ad60e1d5.zip op-kernel-dev-ab4060e858e36129f9319ef0fa055347ad60e1d5.tar.gz | |
[BRIDGE]: fix race on bridge del if
This fixes the RCU race on bridge delete interface. Basically,
the network device has to be detached from the bridge in the first
step (pre-RCU), rather than later. At that point, no more bridge traffic
will come in, and the other code will not think that network device
is part of a bridge.
This should also fix the XEN test problems.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/bridge/br_if.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 91bb895..defcf6a 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -79,7 +79,6 @@ static void destroy_nbp(struct net_bridge_port *p) { struct net_device *dev = p->dev; - dev->br_port = NULL; p->br = NULL; p->dev = NULL; dev_put(dev); @@ -100,6 +99,7 @@ static void del_nbp(struct net_bridge_port *p) struct net_bridge *br = p->br; struct net_device *dev = p->dev; + dev->br_port = NULL; dev_set_promiscuity(dev, -1); spin_lock_bh(&br->lock); |
