summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Moyer <jmoyer@redhat.com>2008-04-29 01:03:48 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-29 08:06:29 -0700
commit39fa00311f21318cc498b139c2cc2830dcad98ff (patch)
tree936eeb3a4046fb9b17cc4297e3b783f49c0a1dc0
parent68ab3d883a2df13f4b93a923bae3a287cbee29d3 (diff)
downloadop-kernel-dev-39fa00311f21318cc498b139c2cc2830dcad98ff.zip
op-kernel-dev-39fa00311f21318cc498b139c2cc2830dcad98ff.tar.gz
aio: fix misleading comments
The FIXME comments are inaccurate. The locking comment over lookup_ioctx() is wrong. Signed-off-by: Jeff Moyer <jmoyer@redhat.com> Signed-off-by: Zach Brown <zach.brown@oracle.com> Signed-off-by: Shen Feng <shen@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/aio.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/aio.c b/fs/aio.c
index a175ad6..99c2352 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -277,7 +277,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
if (ctx->max_reqs == 0)
goto out_cleanup;
- /* now link into global list. kludge. FIXME */
+ /* now link into global list. */
write_lock(&mm->ioctx_list_lock);
ctx->next = mm->ioctx_list;
mm->ioctx_list = ctx;
@@ -553,9 +553,6 @@ int aio_put_req(struct kiocb *req)
return ret;
}
-/* Lookup an ioctx id. ioctx_list is lockless for reads.
- * FIXME: this is O(n) and is only suitable for development.
- */
static struct kioctx *lookup_ioctx(unsigned long ctx_id)
{
struct kioctx *ioctx;
OpenPOWER on IntegriCloud