diff options
author | Stephen Hemminger <shemminger@linux-foundation.org> | 2007-07-01 12:50:35 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-01 11:08:39 -0700 |
commit | 0f4915b9c5d7a35da11bfcff80ae6466cb7b9fc4 (patch) | |
tree | d827b3da44f54cfeaffa81a34fb9774bf04d71b6 | |
parent | 4710bcce8e02257c8a423b7a62ea81d0207582c8 (diff) | |
download | op-kernel-dev-0f4915b9c5d7a35da11bfcff80ae6466cb7b9fc4.zip op-kernel-dev-0f4915b9c5d7a35da11bfcff80ae6466cb7b9fc4.tar.gz |
blink driver power saving
The blink driver wakes up every jiffies which wastes power unnecessarily.
Using a notifier gives same effect. Also add ability to unload module.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
[ We should really just delete the whole thing. The blink driver is
broken in many other ways too -Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/misc/blink.c | 22 |
1 files changed, 20 insertions, 2 deletions
diff --git a/drivers/misc/blink.c b/drivers/misc/blink.c index 634431c..97f7253 100644 --- a/drivers/misc/blink.c +++ b/drivers/misc/blink.c @@ -16,12 +16,30 @@ static void do_blink(unsigned long data) add_timer(&blink_timer); } -static int blink_init(void) +static int blink_panic_event(struct notifier_block *blk, + unsigned long event, void *arg) { - printk(KERN_INFO "Enabling keyboard blinking\n"); do_blink(0); return 0; } +static struct notifier_block blink_notify = { + .notifier_call = blink_panic_event, +}; + +static __init int blink_init(void) +{ + printk(KERN_INFO "Enabling keyboard blinking\n"); + atomic_notifier_chain_register(&panic_notifier_list, &blink_notify); + return 0; +} + +static __exit void blink_remove(void) +{ + del_timer_sync(&blink_timer); + atomic_notifier_chain_unregister(&panic_notifier_list, &blink_notify); +} + module_init(blink_init); +module_exit(blink_remove); |