diff options
| author | Ming Lei <ming.lei@canonical.com> | 2014-08-15 23:16:32 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2014-08-15 12:38:20 -0600 |
| commit | dd840087086f3b93ac20f7472b4fca59aff7b79f (patch) | |
| tree | 7041c173625a6099816b920f8f27c1b044a5fda4 | |
| parent | c9d26423e56ce1ab4d786f92aebecf859d419293 (diff) | |
| download | op-kernel-dev-dd840087086f3b93ac20f7472b4fca59aff7b79f.zip op-kernel-dev-dd840087086f3b93ac20f7472b4fca59aff7b79f.tar.gz | |
blk-mq: fix WARNING "percpu_ref_kill() called more than once!"
Before doing queue release, the queue has been freezed already
by blk_cleanup_queue(), so needn't to freeze queue for deleting
tag set.
This patch fixes the WARNING of "percpu_ref_kill() called more than once!"
which is triggered during unloading block driver.
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | block/blk-mq.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 5189cb1..ac8a041 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1713,14 +1713,10 @@ static void blk_mq_del_queue_tag_set(struct request_queue *q) { struct blk_mq_tag_set *set = q->tag_set; - blk_mq_freeze_queue(q); - mutex_lock(&set->tag_list_lock); list_del_init(&q->tag_set_list); blk_mq_update_tag_set_depth(set); mutex_unlock(&set->tag_list_lock); - - blk_mq_unfreeze_queue(q); } static void blk_mq_add_queue_tag_set(struct blk_mq_tag_set *set, |
