diff options
| author | NeilBrown <neilb@suse.de> | 2011-02-16 13:58:38 +1100 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-02-16 13:58:38 +1100 |
| commit | cbe6ef1d2622e08e272600b3cb6040bed60f0450 (patch) | |
| tree | 03d1ae0fe73404a3bd7850d89c415f3412977693 | |
| parent | f7bee80945155ad0326916486dabc38428c6cdef (diff) | |
| download | op-kernel-dev-cbe6ef1d2622e08e272600b3cb6040bed60f0450.zip op-kernel-dev-cbe6ef1d2622e08e272600b3cb6040bed60f0450.tar.gz | |
md: don't set_capacity before array is active.
If the desired size of an array is set (via sysfs) before the array is
active (which is the normal sequence), we currrently call set_capacity
immediately.
This means that a subsequent 'open' (as can be caused by some
udev-triggers program) will notice the new size and try to probe for
partitions. However as the array isn't quite ready yet the read will
fail. Then when the array is read, as the size doesn't change again
we don't try to re-probe.
So when setting array size via sysfs, only call set_capacity if the
array is already active.
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/md.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 0cc30ec..6818ff4 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4138,10 +4138,10 @@ array_size_store(mddev_t *mddev, const char *buf, size_t len) } mddev->array_sectors = sectors; - set_capacity(mddev->gendisk, mddev->array_sectors); - if (mddev->pers) + if (mddev->pers) { + set_capacity(mddev->gendisk, mddev->array_sectors); revalidate_disk(mddev->gendisk); - + } return len; } |
