diff options
| author | Julia Lawall <julia@diku.dk> | 2011-09-16 08:57:34 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2011-09-22 15:13:12 +0400 |
| commit | 96a99501d6ba0292ea7bd96846053091fc20776c (patch) | |
| tree | cccae7f7a2554c6649f77c32e1e102804bc53c8d | |
| parent | 12b8fc10eaf4e981e9c546d4cfb94d592dc10622 (diff) | |
| download | op-kernel-dev-96a99501d6ba0292ea7bd96846053091fc20776c.zip op-kernel-dev-96a99501d6ba0292ea7bd96846053091fc20776c.tar.gz | |
[SCSI] mpt2sas: take size of pointed value, not pointer
Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *e;
type T;
identifier f;
@@
f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/mpt2sas/mpt2sas_transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c index 15c7980..2307322 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c @@ -163,7 +163,7 @@ _transport_set_identify(struct MPT2SAS_ADAPTER *ioc, u16 handle, return -EIO; } - memset(identify, 0, sizeof(identify)); + memset(identify, 0, sizeof(*identify)); device_info = le32_to_cpu(sas_device_pg0.DeviceInfo); /* sas_address */ |
