summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndi Kleen <andi@firstfloor.org>2009-12-16 12:28:44 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2009-12-16 12:36:18 -0800
commit61cf693159d6a968a7014e24905143f71ed8ddcf (patch)
tree595a4bddf8b005f7345cc123b19f4da1f5d07aa7
parent288f02bbb6e9609cbaf1eb7a9cb97ae45ce090b2 (diff)
downloadop-kernel-dev-61cf693159d6a968a7014e24905143f71ed8ddcf.zip
op-kernel-dev-61cf693159d6a968a7014e24905143f71ed8ddcf.tar.gz
[sysctl] Fix breakage on systems with older glibc
As predicted during code review, the sysctl(2) changes made systems with old glibc nearly unusable. About every command gives a: warning: process `ls' used the deprecated sysctl system call with 1.4 warning in the log. I see this on a SUSE 10.0 system with glibc 2.3.5. Don't warn for this common case. Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--kernel/sysctl_binary.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
index b75dbf4..112533d 100644
--- a/kernel/sysctl_binary.c
+++ b/kernel/sysctl_binary.c
@@ -1399,6 +1399,13 @@ static void deprecated_sysctl_warning(const int *name, int nlen)
{
int i;
+ /*
+ * CTL_KERN/KERN_VERSION is used by older glibc and cannot
+ * ever go away.
+ */
+ if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+ return;
+
if (printk_ratelimit()) {
printk(KERN_INFO
"warning: process `%s' used the deprecated sysctl "
OpenPOWER on IntegriCloud