summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2009-05-28 01:22:57 -0700
committerDavid S. Miller <davem@davemloft.net>2009-05-28 01:22:57 -0700
commit46c37672d7fff0097385eb0cbd01aa0254dad0aa (patch)
treef89ef8cdca3b31b09bacd80f3f7765e893c9ef63
parenta1091aae19b1d9c85d91c86915a611387f67a26b (diff)
downloadop-kernel-dev-46c37672d7fff0097385eb0cbd01aa0254dad0aa.zip
op-kernel-dev-46c37672d7fff0097385eb0cbd01aa0254dad0aa.tar.gz
rtl8187: Remove pointless check in rtl8187_rx_cb().
First of all, it exposes the SKB list implementation. Second of all it's not needed. If we get called here, we successfully enqueued the URB with the linked SKB and such a completion only gets called one time on such an SKB. Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/wireless/rtl818x/rtl8187_dev.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index 6499ccc..3f22cc0 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -321,12 +321,7 @@ static void rtl8187_rx_cb(struct urb *urb)
unsigned long f;
spin_lock_irqsave(&priv->rx_queue.lock, f);
- if (skb->next)
- __skb_unlink(skb, &priv->rx_queue);
- else {
- spin_unlock_irqrestore(&priv->rx_queue.lock, f);
- return;
- }
+ __skb_unlink(skb, &priv->rx_queue);
spin_unlock_irqrestore(&priv->rx_queue.lock, f);
skb_put(skb, urb->actual_length);
OpenPOWER on IntegriCloud