diff options
author | Felipe Balbi <balbi@ti.com> | 2011-12-21 13:13:33 +0200 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2011-12-21 13:24:43 +0200 |
commit | 14ff96e04c0b29736c8c81fbe75e86dd373c8e22 (patch) | |
tree | c4069fac190ad9eeb3daa20882fd45af149dc41b | |
parent | abfbe33410d1931d4c18fa73f3c2cea9688aaad6 (diff) | |
download | op-kernel-dev-14ff96e04c0b29736c8c81fbe75e86dd373c8e22.zip op-kernel-dev-14ff96e04c0b29736c8c81fbe75e86dd373c8e22.tar.gz |
usb: renesas: pipe: convert a long if into a XOR operation
This is just a minor optimization for the long
if we have on the driver.
When we want to check that one input is true
and the other must be false, the bitwise XOR
operator will achieve that for us.
Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r-- | drivers/usb/renesas_usbhs/pipe.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/renesas_usbhs/pipe.c b/drivers/usb/renesas_usbhs/pipe.c index c2559e8..feb06d6 100644 --- a/drivers/usb/renesas_usbhs/pipe.c +++ b/drivers/usb/renesas_usbhs/pipe.c @@ -330,8 +330,7 @@ static u16 usbhsp_setup_pipecfg(struct usbhs_pipe *pipe, if (dir_in) usbhsp_flags_set(pipe, IS_DIR_HOST); - if ((is_host && !dir_in) || - (!is_host && dir_in)) + if (!!is_host ^ !!dir_in) dir |= DIR_OUT; if (!dir) |