diff options
| author | Dmitry Torokhov <dtor@vmware.com> | 2011-02-07 16:02:27 -0800 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2011-05-19 16:55:25 +0930 |
| commit | 9b73a5840c7d5f77e5766626716df13787cb258c (patch) | |
| tree | 5179b149129ee677d3a6fd621608cdc08206b516 | |
| parent | b4bc842802db3314f9a657094da0450a903ea619 (diff) | |
| download | op-kernel-dev-9b73a5840c7d5f77e5766626716df13787cb258c.zip op-kernel-dev-9b73a5840c7d5f77e5766626716df13787cb258c.tar.gz | |
module: do not hide __modver_version_show declaration behind ifdef
Doing so prevents the following warning from sparse:
CHECK kernel/params.c
kernel/params.c:817:9: warning: symbol '__modver_version_show' was not
declared. Should it be static?
since kernel/params.c is never compiled with MODULE being set.
Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
| -rw-r--r-- | include/linux/module.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/linux/module.h b/include/linux/module.h index 4cfebc2..23996ad 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -64,6 +64,9 @@ struct module_version_attribute { const char *version; } __attribute__ ((__aligned__(sizeof(void *)))); +extern ssize_t __modver_version_show(struct module_attribute *, + struct module *, char *); + struct module_kobject { struct kobject kobj; @@ -172,8 +175,6 @@ extern struct module __this_module; #define MODULE_VERSION(_version) MODULE_INFO(version, _version) #else #define MODULE_VERSION(_version) \ - extern ssize_t __modver_version_show(struct module_attribute *, \ - struct module *, char *); \ static struct module_version_attribute ___modver_attr = { \ .mattr = { \ .attr = { \ |
