diff options
| author | Li Zefan <lizf@cn.fujitsu.com> | 2009-06-24 09:53:26 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-06-24 11:02:51 +0200 |
| commit | 2961bf345fd1b736c3db46cad0f69855f67fbe9c (patch) | |
| tree | 2032d3b59b4a93445209b5b1f0428159b61837d2 | |
| parent | c8961ec6da22ea010bf4470a8e0fb3fdad0f11c4 (diff) | |
| download | op-kernel-dev-2961bf345fd1b736c3db46cad0f69855f67fbe9c.zip op-kernel-dev-2961bf345fd1b736c3db46cad0f69855f67fbe9c.tar.gz | |
trace_stat: Don't increment @pos in seq start()
It's wrong to increment @pos in stat_seq_start(). It causes some
stat entries lost when reading stat file, if the output of the file
is larger than PAGE_SIZE.
Reviewed-by: Liming Wang <liming.wang@windriver.com>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A418716.90209@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | kernel/trace/trace_stat.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index c006437..e66f5e4 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c @@ -199,17 +199,13 @@ static void *stat_seq_start(struct seq_file *s, loff_t *pos) mutex_lock(&session->stat_mutex); /* If we are in the beginning of the file, print the headers */ - if (!*pos && session->ts->stat_headers) { - (*pos)++; + if (!*pos && session->ts->stat_headers) return SEQ_START_TOKEN; - } node = rb_first(&session->stat_root); for (i = 0; node && i < *pos; i++) node = rb_next(node); - (*pos)++; - return node; } |
