summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2011-07-23 17:36:38 +0200
committerAl Viro <viro@zeniv.linux.org.uk>2011-07-25 14:25:38 -0400
commitebbb0ef2871bf3f529987313a9146cc42419a8a8 (patch)
treeb833325b05b6e25c976be34f3be69088dbd6d7c1
parente77819e57f0817c6dc7cadd061acd70c604cbce2 (diff)
downloadop-kernel-dev-ebbb0ef2871bf3f529987313a9146cc42419a8a8.zip
op-kernel-dev-ebbb0ef2871bf3f529987313a9146cc42419a8a8.tar.gz
9p: do no return 0 from ->check_acl without actually checking
If we do not want to use ACLs we at least need to perform normal Unix permission checks. From the comment I'm not quite sure that's what is intended, but if 0p wants to do permission checks entirely on the server it needs to do so in ->permission, not in ->check_acl. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/9p/acl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index 8be8785..df4d7a1 100644
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
* On access = client and acl = on mode get the acl
* values from the server
*/
- return 0;
+ return -EAGAIN;
}
acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);
OpenPOWER on IntegriCloud