diff options
| author | Nick Piggin <npiggin@suse.de> | 2007-10-16 01:25:00 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 09:42:55 -0700 |
| commit | 637aff46f94a754207c80c8c64bf1b74f24b967d (patch) | |
| tree | 837fb3196236998c3c3ae44762ed3167ef0256f4 | |
| parent | 2f718ffc16c43a435d12919c75dbfad518abd056 (diff) | |
| download | op-kernel-dev-637aff46f94a754207c80c8c64bf1b74f24b967d.zip op-kernel-dev-637aff46f94a754207c80c8c64bf1b74f24b967d.tar.gz | |
fs: fix data-loss on error
New buffers against uptodate pages are simply be marked uptodate, while the
buffer_new bit remains set. This causes error-case code to zero out parts of
those buffers because it thinks they contain stale data: wrong, they are
actually uptodate so this is a data loss situation.
Fix this by actually clearning buffer_new and marking the buffer dirty. It
makes sense to always clear buffer_new before setting a buffer uptodate.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/buffer.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 09bb80c..9ece6c2 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1813,7 +1813,9 @@ static int __block_prepare_write(struct inode *inode, struct page *page, unmap_underlying_metadata(bh->b_bdev, bh->b_blocknr); if (PageUptodate(page)) { + clear_buffer_new(bh); set_buffer_uptodate(bh); + mark_buffer_dirty(bh); continue; } if (block_end > to || block_start < from) { |
