diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2006-05-16 15:02:12 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-05-16 15:02:12 -0700 |
| commit | 338f7566e5c26a9547e25d54863ae4e4e5c856d1 (patch) | |
| tree | fbe483e07f8680a7718e02b869cdf5e042e2ec7b | |
| parent | 716f8954fb3029ca2df52a986b60af8d06f093ee (diff) | |
| download | op-kernel-dev-338f7566e5c26a9547e25d54863ae4e4e5c856d1.zip op-kernel-dev-338f7566e5c26a9547e25d54863ae4e4e5c856d1.tar.gz | |
[PKT_SCHED]: Potential jiffy wrap bug in dev_watchdog().
There is a potential jiffy wraparound bug in the transmit watchdog
that is easily avoided by using time_after().
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/sch_generic.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 31eb837..138ea92 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -193,8 +193,10 @@ static void dev_watchdog(unsigned long arg) netif_running(dev) && netif_carrier_ok(dev)) { if (netif_queue_stopped(dev) && - (jiffies - dev->trans_start) > dev->watchdog_timeo) { - printk(KERN_INFO "NETDEV WATCHDOG: %s: transmit timed out\n", dev->name); + time_after(jiffies, dev->trans_start + dev->watchdog_timeo)) { + + printk(KERN_INFO "NETDEV WATCHDOG: %s: transmit timed out\n", + dev->name); dev->tx_timeout(dev); } if (!mod_timer(&dev->watchdog_timer, jiffies + dev->watchdog_timeo)) |
