summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorakpm@osdl.org <akpm@osdl.org>2005-04-16 15:23:57 -0700
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-16 15:23:57 -0700
commit7a228aaa879c119c9fb9b9d7e062ac13cb1a9079 (patch)
tree7a79aef406aa44dcbe887e69656aef61ed98dd9a
parent7aa52f5128b06d1df9b2ee65c06d401af27da0a4 (diff)
downloadop-kernel-dev-7a228aaa879c119c9fb9b9d7e062ac13cb1a9079.zip
op-kernel-dev-7a228aaa879c119c9fb9b9d7e062ac13cb1a9079.tar.gz
[PATCH] arm: add comment about dma_supported()
) From: Russell King <rmk+lkml@arm.linux.org.uk> The ARM dma_supported() is rather basic, and I don't think it takes into account everything that it should do (eg, whether the mask agrees with what we'd return for GFP_DMA allocations). Note this. Signed-off-by: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--include/asm-arm/dma-mapping.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/include/asm-arm/dma-mapping.h b/include/asm-arm/dma-mapping.h
index 925d016..d62ade4 100644
--- a/include/asm-arm/dma-mapping.h
+++ b/include/asm-arm/dma-mapping.h
@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, size_t size, int rw);
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
OpenPOWER on IntegriCloud