summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2012-02-16 11:03:29 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2012-02-27 18:09:46 +0100
commit5d1333fcce84e77ec865f6b09006401ed3f564b5 (patch)
tree01a6cafb8fe43c202330332d35cdea472bff8d75
parenteadb29a9c52eb14a84b94fc29bb1cfa93ddc653e (diff)
downloadop-kernel-dev-5d1333fcce84e77ec865f6b09006401ed3f564b5.zip
op-kernel-dev-5d1333fcce84e77ec865f6b09006401ed3f564b5.tar.gz
drm/i915: error_buffer->ring should be signed
gcc seems to get uber-anal recently about these things. Clarification from Dan Carpenter: "Sorry, I should have said that it's not a gcc warning, it's a smatch thing. But also it's not uber-anal. It's the exact level of anality which is required to make the == -1 test work. You can compare unsigned int and longs to -1 and it works but for smaller types it doesn't." Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/i915/i915_drv.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index b839728..35833fc 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -199,7 +199,7 @@ struct drm_i915_error_state {
u32 tiling:2;
u32 dirty:1;
u32 purgeable:1;
- u32 ring:4;
+ s32 ring:4;
u32 cache_level:2;
} *active_bo, *pinned_bo;
u32 active_bo_count, pinned_bo_count;
OpenPOWER on IntegriCloud