diff options
| author | Bjarke Istrup Pedersen <gurligebis@gentoo.org> | 2012-05-04 14:01:45 -0700 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2012-05-04 14:40:07 -0700 |
| commit | d1d0589a565a2528a044cfd680141c3e2db18d0a (patch) | |
| tree | c07c1f87a23e734be4d09b7465b22b06d99b9c3e | |
| parent | 7c77cda0fe742ed07622827ce80963bbeebd1e3f (diff) | |
| download | op-kernel-dev-d1d0589a565a2528a044cfd680141c3e2db18d0a.zip op-kernel-dev-d1d0589a565a2528a044cfd680141c3e2db18d0a.tar.gz | |
arch/x86/platform/geode/net5501.c: change active_low to 0 for LED driver
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts itself,
regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it makes the LED
behave correctly, where "none" turns it off, and "default-on" turns it on,
when echoed onto the trigger "file" in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Link: http://lkml.kernel.org/r/20120504210146.62186A018B@akpm.mtv.corp.google.com
Cc: Philip Prindeville <philipp@redfish-solutions.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
| -rw-r--r-- | arch/x86/platform/geode/net5501.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c index 66d377e..646e3b5 100644 --- a/arch/x86/platform/geode/net5501.c +++ b/arch/x86/platform/geode/net5501.c @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = { .name = "net5501:1", .gpio = 6, .default_trigger = "default-on", - .active_low = 1, + .active_low = 0, }, }; |
