summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDanny Kukawka <danny.kukawka@bisect.de>2012-01-24 16:44:42 +0100
committerTomi Valkeinen <tomi.valkeinen@ti.com>2012-01-25 13:48:34 +0200
commitcc1d3e032df53d83d0ca4d537d8eb67eb5b3e808 (patch)
treeea2763286111456ae48c0e3b631d7132521f376d
parent1149c74419179d57fdcd506424da2444755e65d9 (diff)
downloadop-kernel-dev-cc1d3e032df53d83d0ca4d537d8eb67eb5b3e808.zip
op-kernel-dev-cc1d3e032df53d83d0ca4d537d8eb67eb5b3e808.tar.gz
OMAPDSS: VENC: fix NULL pointer dereference in DSS2 VENC sysfs debug attr on OMAP4
Commit ba02fa37de80bea10d706f39f076dd848348320a disabled the venc driver registration on OMAP4. Since the driver never gets probed/initialised your get a dereferenceed NULL pointer if you try to get info from /sys/kernel/debug/omapdss/venc Return info message about disabled venc if venc_dump_regs() gets called. Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r--drivers/video/omap2/dss/venc.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c
index b3e9f90..82865be 100644
--- a/drivers/video/omap2/dss/venc.c
+++ b/drivers/video/omap2/dss/venc.c
@@ -699,6 +699,11 @@ void venc_dump_regs(struct seq_file *s)
{
#define DUMPREG(r) seq_printf(s, "%-35s %08x\n", #r, venc_read_reg(r))
+ if (cpu_is_omap44xx()) {
+ seq_printf(s, "VENC currently disabled on OMAP44xx\n");
+ return;
+ }
+
if (venc_runtime_get())
return;
OpenPOWER on IntegriCloud