summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLennert Buytenhek <buytenh@wantstofly.org>2009-11-30 18:13:34 +0100
committerJohn W. Linville <linville@tuxdriver.com>2009-12-07 16:51:21 -0500
commit3db95e50c8813d8ed04a1ec7cd7b77dba7c81c80 (patch)
tree3e23928f15578d9a3bb6e9dec0ad638151ce9a27
parent89b872e2e476833cde8aaac658c75817f67e8f81 (diff)
downloadop-kernel-dev-3db95e50c8813d8ed04a1ec7cd7b77dba7c81c80.zip
op-kernel-dev-3db95e50c8813d8ed04a1ec7cd7b77dba7c81c80.tar.gz
mwl8k: don't forget to call pci_disable_device()
Don't forget to call pci_disable_device() if pci_request_regions() fails during probe. Signed-off-by: Lennert Buytenhek <buytenh@marvell.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/mwl8k.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index e59a926..76a6071 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -3378,7 +3378,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
if (rc) {
printk(KERN_ERR "%s: Cannot obtain PCI resources\n",
MWL8K_NAME);
- return rc;
+ goto err_disable_device;
}
pci_set_master(pdev);
@@ -3609,6 +3609,8 @@ err_iounmap:
err_free_reg:
pci_release_regions(pdev);
+
+err_disable_device:
pci_disable_device(pdev);
return rc;
OpenPOWER on IntegriCloud