summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Bird <tim.bird@am.sony.com>2011-09-21 13:19:12 -0700
committerJason Wessel <jason.wessel@windriver.com>2012-03-22 15:07:16 -0500
commitb8adde8ddec9ff62a21564fa8020b5463e70d4de (patch)
tree750515b98a74e80569148371754869956cea039d
parentbec4d62ead8096e433d624d9339893f50badd992 (diff)
downloadop-kernel-dev-b8adde8ddec9ff62a21564fa8020b5463e70d4de.zip
op-kernel-dev-b8adde8ddec9ff62a21564fa8020b5463e70d4de.tar.gz
kdb: Avoid using dbg_io_ops until it is initialized
This fixes a bug with setting a breakpoint during kdb initialization (from kdb_cmds). Any call to kdb_printf() before the initialization of the kgdboc serial console driver (which happens much later during bootup than kdb_init), results in kernel panic due to the use of dbg_io_ops before it is initialized. Signed-off-by: Tim Bird <tim.bird@am.sony.com> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
-rw-r--r--kernel/debug/kdb/kdb_io.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 4802eb5..9b5f17d 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -689,7 +689,7 @@ kdb_printit:
if (!dbg_kdb_mode && kgdb_connected) {
gdbstub_msg_write(kdb_buffer, retlen);
} else {
- if (!dbg_io_ops->is_console) {
+ if (dbg_io_ops && !dbg_io_ops->is_console) {
len = strlen(kdb_buffer);
cp = kdb_buffer;
while (len--) {
OpenPOWER on IntegriCloud