diff options
| author | Krishna Gudipati <kgudipat@brocade.com> | 2011-07-20 16:59:44 -0700 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2011-07-27 14:44:06 +0400 |
| commit | 9afbcfab74d26051702862b57c0115f71477a3cc (patch) | |
| tree | 4ed2dd5c6d0334c21cb191540942a41d9290248a | |
| parent | 7826f304b1efa5ab839cf029742290f51c4fa009 (diff) | |
| download | op-kernel-dev-9afbcfab74d26051702862b57c0115f71477a3cc.zip op-kernel-dev-9afbcfab74d26051702862b57c0115f71477a3cc.tar.gz | |
[SCSI] bfa: use negative error return values in all functions
Signed-off-by: Krishna Gudipati <kgudipat@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/bfa/bfad_bsg.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c index 88bfa92..3601508 100644 --- a/drivers/scsi/bfa/bfad_bsg.c +++ b/drivers/scsi/bfa/bfad_bsg.c @@ -56,7 +56,7 @@ bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd) spin_lock_irqsave(&bfad->bfad_lock, flags); if (bfad->disable_active) { spin_unlock_irqrestore(&bfad->bfad_lock, flags); - return EBUSY; + return -EBUSY; } bfad->disable_active = BFA_TRUE; @@ -390,7 +390,7 @@ bfad_iocmd_lport_get_rports(struct bfad_s *bfad, void *cmd, void *iocmd_bufptr; if (iocmd->nrports == 0) - return EINVAL; + return -EINVAL; if (bfad_chk_iocmd_sz(payload_len, sizeof(struct bfa_bsg_lport_get_rports_s), @@ -1516,7 +1516,7 @@ static int bfad_iocmd_handler(struct bfad_s *bfad, unsigned int cmd, void *iocmd, unsigned int payload_len) { - int rc = EINVAL; + int rc = -EINVAL; switch (cmd) { case IOCMD_IOC_ENABLE: @@ -1704,10 +1704,10 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned int cmd, void *iocmd, rc = bfad_iocmd_porglog_get(bfad, iocmd); break; default: - rc = EINVAL; + rc = -EINVAL; break; } - return -rc; + return rc; } static int |
