summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2006-08-21 08:33:23 +0200
committerJens Axboe <axboe@suse.de>2006-08-21 08:33:23 +0200
commit78bd4d484f81a611ef6ff02f909e576cb9aac7f2 (patch)
tree9ba30e54a16d47b3cf4a9ea0123f7261d52462ab
parentef7d1b244fa6c94fb76d5f787b8629df64ea4046 (diff)
downloadop-kernel-dev-78bd4d484f81a611ef6ff02f909e576cb9aac7f2.zip
op-kernel-dev-78bd4d484f81a611ef6ff02f909e576cb9aac7f2.tar.gz
[PATCH] sys_ioprio_set: minor do_each_thread+break fix
From include/linux/sched.h: * Careful: do_each_thread/while_each_thread is a double loop so * 'break' will not work as expected - use goto instead. */ Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Signed-off-by: Jens Axboe <axboe@suse.de>
-rw-r--r--fs/ioprio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ioprio.c b/fs/ioprio.c
index 93aa571..3db3103 100644
--- a/fs/ioprio.c
+++ b/fs/ioprio.c
@@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which, int who, int ioprio)
continue;
ret = set_task_ioprio(p, ioprio);
if (ret)
- break;
+ goto free_uid;
} while_each_thread(g, p);
-
+free_uid:
if (who)
free_uid(user);
break;
OpenPOWER on IntegriCloud