summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Hansen <haveblue@us.ibm.com>2007-07-15 23:41:14 -0700
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-16 09:05:48 -0700
commite3a68e30d28dbc6981dfc3d6ceddbfa2f885fe4e (patch)
treef15372ae04f4eaea734c1c6935ae65887acf4c3c
parent6b86e854f71600c809536502a0efa9d4e384fb23 (diff)
downloadop-kernel-dev-e3a68e30d28dbc6981dfc3d6ceddbfa2f885fe4e.zip
op-kernel-dev-e3a68e30d28dbc6981dfc3d6ceddbfa2f885fe4e.tar.gz
ext3: remove extra IS_RDONLY() check
ext3_change_inode_journal_flag() is only called from one location: ext3_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen <haveblue@us.ibm.com> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/ext3/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 2a85ddee..de4e316 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -3195,7 +3195,7 @@ int ext3_change_inode_journal_flag(struct inode *inode, int val)
*/
journal = EXT3_JOURNAL(inode);
- if (is_journal_aborted(journal) || IS_RDONLY(inode))
+ if (is_journal_aborted(journal))
return -EROFS;
journal_lock_updates(journal);
OpenPOWER on IntegriCloud