summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatti Linnanvuori <mattilinnanvuori@yahoo.com>2008-01-15 06:25:27 -0800
committerJeff Garzik <jeff@garzik.org>2008-01-18 14:41:49 -0500
commitce3ba1399d2ba81b3699a82649df0cd8223c6662 (patch)
treec247fcfc5c004c4e76242ead710bb36709954dc6
parentbe63a21c9573fbf88106ff0f030da5974551257b (diff)
downloadop-kernel-dev-ce3ba1399d2ba81b3699a82649df0cd8223c6662.zip
op-kernel-dev-ce3ba1399d2ba81b3699a82649df0cd8223c6662.tar.gz
Documentation: add a guideline for hard_start_xmit method
Add a guideline not to modify SKBs. Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r--Documentation/networking/driver.txt5
1 files changed, 4 insertions, 1 deletions
diff --git a/Documentation/networking/driver.txt b/Documentation/networking/driver.txt
index 4f7da5a..ea72d2e 100644
--- a/Documentation/networking/driver.txt
+++ b/Documentation/networking/driver.txt
@@ -61,7 +61,10 @@ Transmit path guidelines:
2) Do not forget to update netdev->trans_start to jiffies after
each new tx packet is given to the hardware.
-3) Do not forget that once you return 0 from your hard_start_xmit
+3) A hard_start_xmit method must not modify the shared parts of a
+ cloned SKB.
+
+4) Do not forget that once you return 0 from your hard_start_xmit
method, it is your driver's responsibility to free up the SKB
and in some finite amount of time.
OpenPOWER on IntegriCloud