summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSathya Narayanan <sathyan@teamf1.com>2008-07-01 10:58:05 +0200
committerJeff Garzik <jgarzik@redhat.com>2008-07-04 08:17:18 -0400
commitab9b30cc3ec868fab8764d710193107fbeedbd0f (patch)
treef596086e32685b9c1f885b3e8edddf4b72d3b406
parent773212337941c5e26a05989532943877d72a2c83 (diff)
downloadop-kernel-dev-ab9b30cc3ec868fab8764d710193107fbeedbd0f.zip
op-kernel-dev-ab9b30cc3ec868fab8764d710193107fbeedbd0f.tar.gz
ibm_newemac: Fixes kernel crashes when speed of cable connected changes
The descriptor pointers were not initialized to NIL values, so it was poiniting to some random addresses which was completely invalid. This fix takes care of initializing the descriptor to NIL values and clearing the valid descriptors on clean ring operation. Signed-off-by: Sathya Narayanan <sathyan@teamf1.com> Signed-off-by: Stefan Roese <sr@denx.de> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
-rw-r--r--drivers/net/ibm_newemac/core.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 5d2108c..ca63fa0 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -2719,6 +2719,8 @@ static int __devinit emac_probe(struct of_device *ofdev,
/* Clean rings */
memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor));
memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor));
+ memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *));
+ memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *));
/* Attach to ZMII, if needed */
if (emac_has_feature(dev, EMAC_FTR_HAS_ZMII) &&
OpenPOWER on IntegriCloud