diff options
| author | Alan Cox <alan@redhat.com> | 2009-01-11 19:48:34 +0000 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-12 16:37:00 -0800 |
| commit | 21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac (patch) | |
| tree | 9f3c5434966bb4d4817215bc8a3617362812648f | |
| parent | c774bda2fdc5412124a854a791d9f6f52936ff81 (diff) | |
| download | op-kernel-dev-21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac.zip op-kernel-dev-21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac.tar.gz | |
neo: Remove a bogus NULL check
Julia Lawall found an un-needed check in the neo driver. Her patch moves
the check to cover the code dereferencing it, however it cannot be NULL
anyway so remove the NULL check instead.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/serial/jsm/jsm_neo.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/serial/jsm/jsm_neo.c b/drivers/serial/jsm/jsm_neo.c index b7584ca..e6390d0 100644 --- a/drivers/serial/jsm/jsm_neo.c +++ b/drivers/serial/jsm/jsm_neo.c @@ -577,9 +577,6 @@ static void neo_parse_modem(struct jsm_channel *ch, u8 signals) jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev, "neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals); - if (!ch) - return; - /* Scrub off lower bits. They signify delta's, which I don't care about */ /* Keep DDCD and DDSR though */ msignals &= 0xf8; |
