diff options
| author | Arjan van de Ven <arjan@linux.intel.com> | 2008-07-25 19:45:40 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 12:00:07 -0700 |
| commit | 5c752ad9f35910ff1912b3f3ae82878178ddc432 (patch) | |
| tree | 4ac627f9cdd7f0e1b0557b9b5c4838587c1c0890 | |
| parent | 5cd2b459d326a424671dcd95f038649f7bf7cb96 (diff) | |
| download | op-kernel-dev-5c752ad9f35910ff1912b3f3ae82878178ddc432.zip op-kernel-dev-5c752ad9f35910ff1912b3f3ae82878178ddc432.tar.gz | |
Use WARN() in fs/
Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/buffer.c | 3 | ||||
| -rw-r--r-- | fs/namespace.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 5fd497c..f958050 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1214,8 +1214,7 @@ void __brelse(struct buffer_head * buf) put_bh(buf); return; } - printk(KERN_ERR "VFS: brelse: Trying to free free buffer\n"); - WARN_ON(1); + WARN(1, KERN_ERR "VFS: brelse: Trying to free free buffer\n"); } /* diff --git a/fs/namespace.c b/fs/namespace.c index 4f6f763..f30b11e 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -309,10 +309,9 @@ static void handle_write_count_underflow(struct vfsmount *mnt) */ if ((atomic_read(&mnt->__mnt_writers) < 0) && !(mnt->mnt_flags & MNT_IMBALANCED_WRITE_COUNT)) { - printk(KERN_DEBUG "leak detected on mount(%p) writers " + WARN(1, KERN_DEBUG "leak detected on mount(%p) writers " "count: %d\n", mnt, atomic_read(&mnt->__mnt_writers)); - WARN_ON(1); /* use the flag to keep the dmesg spam down */ mnt->mnt_flags |= MNT_IMBALANCED_WRITE_COUNT; } |
